Problem
Currently we have configuration params cleanup and skip_cleanup_if_failed.
Despite their names sound similar, they are responsible for completely different things: cleanup controls the database re-creation before each test, and skip_cleanup_if_failed controls whether records, added by haveInDatabase() should be erased after the test.
Suggested fix
It would be good to distinguish these two 'cleanups' in documentation and in the names of config params in next major versions.
For example, to rename cleanup to repopulate (since we have populate responsible for initial database creation).
Problem
Currently we have configuration params
cleanupandskip_cleanup_if_failed.Despite their names sound similar, they are responsible for completely different things:
cleanupcontrols the database re-creation before each test, andskip_cleanup_if_failedcontrols whether records, added byhaveInDatabase()should be erased after the test.Suggested fix
It would be good to distinguish these two 'cleanups' in documentation and in the names of config params in next major versions.
For example, to rename
cleanuptorepopulate(since we havepopulateresponsible for initial database creation).