[codex] Fix local agent discovery imports#738
Open
brandonkachen wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes local agent discovery so loading
.agentsno longer recurses into known non-agent/support directories that can contain executable scripts.Root Cause
The SDK local agent loader recursively imported every JS/TS-like file under
.agentsexceptskills/. That meant unrelated executable scripts, including quarantined skill scripts under directories likeskills-quarantine, could run top-level side effects while Freebuff or Codebuff was only trying to discover local agents.Changes
node_modules,scripts,skills, andskills-*during local agent discovery.Validation
bun test sdk/src/__tests__/load-agents.test.tsbun run --cwd sdk typecheckgit diff --check