fix Deprecated since 3.10 zipimporter.load_module. fix #32

Author: ClericPy

README.md

@@ -77,9 +77,8 @@ So, what could `zipapps` be?
 
 ## 4. Activate the `.pyz` environment
 
-1. one way is use `zipimport` (Recommended)
-   1. load from pyz file
-      1. python < 3.10: `import zipimport; zipimport.zipimporter('bottle.pyz').load_module("ensure_zipapps")`
+1. use `zipimport` (Recommended)
+   1. `zipimport.zipimporter("some_lib_venv.pyz").find_spec("ensure_zipapps").loader.load_module("ensure_zipapps")`
    2. automatically unzip cache, and add the path to sys.path
       1. it can be run multiple times
 2. if they are all pure-python code and **no need to decompress**

changelog.md

@@ -12,6 +12,7 @@
     - Or `zipapps.exe ...` on Windows, or `zipapps` on Unix
   - Added `--uv` option to accept a path to uv, speeding up `pip install`
   - Added `--freeze-deps` as an alias for `--freeze-reqs`
+  - fix Deprecated since 3.10 `zipimporter.load_module`
 - 2024.08.07
   - [**Compatible WARNING**]: update `sys_paths` insert index from `-1` to `0`
   - disable `--download-python`, use `python -m zipapps.download_python` instead

test_utils.py

@@ -407,7 +407,9 @@ def test_env_usage():
     _clean_paths(root=False)
     create_app(output="bottle_env.pyz", unzip="bottle", pip_args=["bottle"])
     # activate sys.path and unzip cache
-    zipimport.zipimporter("bottle_env.pyz").load_module("ensure_zipapps")
+    spec = zipimport.zipimporter("bottle_env.pyz").find_spec("ensure_zipapps")
+    if spec and spec.loader:
+        spec.loader.load_module("ensure_zipapps")
     import bottle
 
     # using app unzip cache for `import ensure_zipapps`
@@ -762,7 +764,11 @@ def main():
 
     count = 0
     start = 0
-    items = [(name, func) for name, func in globals().items() if name.startswith("test_") and inspect.isfunction(func)]
+    items = [
+        (name, func)
+        for name, func in globals().items()
+        if name.startswith("test_") and inspect.isfunction(func)
+    ]
     name_list = ""
     for name, func in items:
         if name_list and name not in name_list:

zipapps/__main__.py

@@ -407,7 +407,7 @@ def main():
         default="",
         dest="uv_path",
         help="the executable path of python-uv, to speed up pip install",
-    )  # internal use only
+    )
     if len(sys.argv) == 1:
         parser.print_help()
         handle_win32_embeded()

zipapps/activate_zipapps.py

@@ -9,10 +9,14 @@ def activate(path=None):
     path_str = path.absolute().as_posix()
     if zipfile.is_zipfile(path_str):
         try:
-            _tmp = zipimport.zipimporter(path_str).load_module("ensure_zipapps")
-            modules.pop(_tmp.__name__, None)
-            del _tmp
-            return True
+            spec = zipimport.zipimporter(path_str).find_spec("ensure_zipapps")
+            if spec and spec.loader:
+                _tmp = spec.loader.load_module("ensure_zipapps")
+                modules.pop(_tmp.__name__, None)
+                del _tmp
+                return True
+            else:
+                raise ImportError(path_str)
         except ImportError as err:
             stderr.write(f"WARNING: activate failed for {err!r}\n")
             raise err

zipapps/main.py

@@ -224,6 +224,7 @@ def kwargs(self):
             unzip_exclude=self.unzip_exclude,
             chmod=self.chmod,
             clear_zipapps_self=self.clear_zipapps_self,
+            uv_path=self.uv_path,
         )
 
     def ensure_args(self):