Module loading error when setting up typescript-tools.nvim with lze

[kohane27]

Hello! Hope you are doing well.

flake.nix:

  lspsAndRuntimeDeps = with pkgs; {
    runtime = [
      universal-ctags
      stdenv.cc.cc
      nodePackages_latest.typescript
      nodePackages_latest.typescript-language-server
    ];
  };

lua/custom/init.lua:

require("custom.plugins")
require("custom.lsp")

lua/custom/plugins/init.lua:

require("lze").load({ { import = "custom.plugins.lsp.typescript-tools" } })

lua/custom/plugins/lsp/typescript-tools/init.lua:

return {
  {
    "typescript-tools.nvim",
    dep_of = { "nvim-lspconfig" },
    after = function(plugin)
      require("typescript-tools").setup({
        -- disable formatting because using `prettier`
        on_attach = function(client, bufnr)
          client.server_capabilities.documentFormattingProvider = false
          client.server_capabilities.documentRangeFormattingProvider = false
        end,
      })
    end,
  },
}

I got the error Failed to run 'after' hook for typescript-tools.nvim: ...-source/lua/custom/plugins/lsp/typescript-tools/init.lua:6: loop or previous error loading module 'typescript-tools'

What I have done and tried

1. Check ~/.local/state/nixCats-nvim/lsp.log and no error (because the plugin is not even loaded)
2. Run NixCats pawsible and confirmed that the name is correct, i.e., typescript-tools.nvim
3. Add dep_of = { "nvim-lspconfig" } to make sure typescript-tools.nvim loads after nvim-lspconfig
4. typescript-tools.nvim users have success with using nix, i.e., feat: find global tsserver from Nix store pmizio/typescript-tools.nvim#187

Any help is much appreciated. Thank you!

[BirdeeHub]

dep_of makes it load before not after. You would want to have lspconfig be dep_of this if you want this to load after.

It's a weird error message but maybe it's just erroring while trying to run it due to needing to be ran after?

Are you using the most up to date version of lze?

I pushed a big change yesterday, and I'm curious if this error is a consequence of them, or conversely if the changes fix the bug. But I would assume they wouldn't have any effect on this scenario.

I think lze is just intercepting another error and giving you a bad message instead of the actual one.

But yeah if this needs to load AFTER lspconfig, then this is wrong, because this is explicitly telling it to load BEFORE lspconfig.

dep_of means, the other thing depends on this thing, so load this thing first.

[kohane27]

Apologies for the wrong repo.

I have added dep_of = { "typescript-tools.nvim" } to my lua/custom/lsp/init.lua:

local servers = {}

servers.bashls = {}
servers.dockerls = {}
servers.eslint = {}

require("lze").load({
  {
    "nvim-lspconfig",
    dep_of = { "typescript-tools.nvim" },
    event = "FileType",
    after = function(plugin)
      for server_name, cfg in pairs(servers) do
        local capabilities = vim.lsp.protocol.make_client_capabilities()
        capabilities = vim.tbl_deep_extend("force", capabilities, require("cmp_nvim_lsp").default_capabilities())
        require("lspconfig")[server_name].setup({
          capabilities = capabilities,
          settings = cfg,
          filetypes = (cfg or {}).filetypes,
          cmd = (cfg or {}).cmd,
          root_pattern = (cfg or {}).root_pattern,
        })
      end
    end,
  }
})

I still got the same error. I tried lazy = false but still to no avail:

lua/custom/plugins/lsp/typescript-tools/init.lua:

return {
  {
    "typescript-tools.nvim",
    lazy = false,
    after = function(plugin)
      require("typescript-tools").setup({})
    end,
  },
}

I had been trying to fix this error for this plugin on and off for about a week; so I don't think it's yesterday changes.

Is there any log from nixCats-nvim that would be helpful to debug? Thank you again.

[BirdeeHub]

If it's in :NixCats pawsible under allPlugins.opt then that's kinda all nixCats knows about.

The nixCats plugin is technically a plugin but it's basically just a table with some get functions it's pretty dumb despite being useful. It doesn't have any other runtime parts.

Does it work if you load it at startup? You might just have to do that in the meantime. Currently walking up a big hill so that I can skate down it but maybe I can look into the requirements of the plugin later and make some better guesses.

You could try using a pcall on the setup function and printing the error intentionally just in case it gives you a better error?

[BirdeeHub]

Lze does have a lze.state that you can view to see pending plugins, idk if it would help much here tho I think trying to get the best error message out of it you can is likely a better bet for now.

[kohane27]

Moving it to startupPlugins works!

          startupPlugins = {
            startup = with pkgs.vimPlugins; {
              always = [ lze vim-repeat ];
              colorscheme = [ kanagawa-nvim ];
              lib = [
                plenary-nvim
                dressing-nvim
                nui-nvim
                nvim-web-devicons
                nvim-nio
                typescript-tools-nvim
              ];
            };
          };

I still can use lze to load the typescript-tools.nvim config:

lua/custom/plugins/init.lua:

require("lze").load({ { import = "custom.plugins.lsp.typescript-tools" } })

lua/custom/plugins/lsp/typescript-tools/init.lua:

return {
  {
    "typescript-tools.nvim",
    after = function(plugin)
      require("typescript-tools").setup({
        on_attach = function(client, bufnr)
          client.server_capabilities.documentFormattingProvider = false
          client.server_capabilities.documentRangeFormattingProvider = false
        end,
      })
    end,
  },
}

Thank you for the pointer! I don't mind loading it at startup because at least I can get it to work. Thank you again! Enjoy your walk:)

[BirdeeHub]

I'm longboard dancing down an entire city lol

I get off the train kinda at the top and go all the way to the water once a week or so, but I'm usually on my phone once on the way up and once halfway down (this reply) XD

Glad you have a working solution for now, I can take a look and see if I have any guesses as to what was going on later but I'm glad it works at least!

[kohane27]

Sigh, my bad. The following is from my lazy.nvim-managed config without any nix:

return {
  "pmizio/typescript-tools.nvim",
  opts = {
    on_attach = function(client, bufnr)
      client.server_capabilities.documentFormattingProvider = false
      client.server_capabilities.documentRangeFormattingProvider = false
    end,
  },
}

So I didn't lazy load it even before migrating to nixCats-nvim. Maybe that's why putting it to startupPlugins works.

But I still don't understand why the following would not work:

lua/custom/plugins/init.lua:

require("lze").load({ { import = "custom.plugins.lsp.typescript-tools" } })

lua/custom/plugins/lsp/typescript-tools/init.lua:

return {
  {
    "typescript-tools.nvim",
    lazy = false,
    after = function(plugin)
      require("typescript-tools").setup({
        on_attach = function(client, bufnr)
          client.server_capabilities.documentFormattingProvider = false
          client.server_capabilities.documentRangeFormattingProvider = false
        end,
      })
    end,
  },
}

That is, I explicitly set lazy = false. I'd love to gain a better understanding. Any idea is much appreciated. Thank you again, and have fun:)

[BirdeeHub]

There are slight differences in how things are loaded when loading via packadd from the opt directory rather than loading immediately from the start directory.

For example, after directories in things loaded via packadd are not sourced, leading to issues with things like cmp sources.

Plugin authors are meant to not use those.

The plugin you linked has queries directory for treesitter? I am unsure if those work when loaded via packadd or not, although I would be surprised if that were the cause of the hard error, I would instead expect just nothing to happen if that were the issue

[BirdeeHub]

but yeah honestly not super sure on this one.

Your second one with lazy = false would work if you had it in startupPlugins, although thats kinda just because calling packadd when its already loaded doesnt error.

But because its still loading from opt via packadd, even though it does so immediately, it doesnt work quite exactly like being in the start directory. lazy = false with it in your opt directory just means its loaded immediately via packadd when the call to lze.load is done being processed.

But yeah the default load function for plugin specs is just vim.cmd.packadd, you can override it if something isnt working, such as for cmp sources which also need their after directory sourced.