aria2 wrapper ignores generated config file

[rachitvrma]

{
  flake.wrappers.aria2 =
    {
      wlib,
      lib,
      pkgs,
      config,
      ...
    }:
    let
      formatLine =
        n: v:
        let
          formatValue = v: if builtins.isBool v then (if v then "true" else "false") else toString v;
        in
        "${n}=${formatValue v}";

      configFile = pkgs.writeText "aria2Wrapped.conf" (
        lib.concatStringsSep "\n" (lib.mapAttrsToList formatLine config.settings) + "\n"
      );
    in
    {
      imports = [ wlib.modules.default ];

      options = {
        settings = lib.mkOption {
          type =
            with lib.types;
            attrsOf (oneOf [
              bool
              float
              int
              str
            ]);
          default = {
            continue = true;
            dir = "/home/krish/Downloads";
            input-file = "/home/krish/Downloads/.aria_downloads.conf";
            file-allocation = "none";
            log-level = "warn";
            max-connection-per-server = 4;
            min-split-size = "5M";
            on-download-complete = "exit";
            auto-file-renaming = false;
          };
          description = "Settings to be wrapped with aria2 binary";
        };
      };
      config = {
        package = pkgs.aria2;
        # exePath = ;
        flags = {
          "--conf-path" = configFile;
        };
        flagSeparator = "=";
      };
    };

}

On nix build .#aria2 creates result-man and result-bin. Generates the intended wrapper only when nix build .#aria2.out is executed.

[BirdeeHub]

no idea, I can try it out maybe later today.

[rachitvrma]

Wrapper works with

...
environment.systemPackages = with self.packages.${packages.stdenv.hostPlatform.system}; [
    aria2.out # Works as intended, wrapped binary
    # aria2 # Original wrapper, config is not passed to it
];
...

[BirdeeHub]

ah its not being passed to it at all

It is only wrapping ${passthru "out"}

Something would need to be added to say if you want the thing in all the outputs, or specific outputs, or whatever, because right now it builds the wrapper script to "out"

In the meantime, the workaround should be something like:

  config.drv.buildPhase = ''
    runHook preBuild
    rm $bin/bin/aria2
    cp $out/bin/aria2 $bin/bin
    runHook postBuild
  '';

[rachitvrma]

Thanks for the workaround. Would you be open to a PR that integrates this? I'd be happy to submit it with this workaround.

[BirdeeHub]

You mean, for aria2? Or for the feature?

For aria2, sure.

Regardless of what I add for that, that workaround would continue to work anyway. Because we make it, we can copy it.

Im not entirely sure how I want to address this yet.

Because, like, this is actually the desired goal is to copy the wrapper to that output as well, and out is the default output, it is maybe fair to assume people will always want to build it at least there? IDK.

I will sit with it, but for now, thats the way to do it.

[rachitvrma]

Made a PR for aria2.