Merge pull request #791 from skoeva/mns-preview

aks-desktop: Stop requiring ManagedNamespacePreview

Author: skoeva

Localize/locales/en/plugin-translation.json

@@ -221,7 +221,6 @@
   "Creating the trigger issue for the Copilot coding agent.": "Creating the trigger issue for the Copilot coding agent.",
   "Creating...": "Creating...",
   "Current Replicas": "Current Replicas",
-  "Current state": "Current state",
   "Degraded": "Degraded",
   "Delete project": "Delete project",
   "Delete Project": "Delete Project",
@@ -443,8 +442,6 @@
   "Login timeout. Please try again.": "Login timeout. Please try again.",
   "Managed Identity": "Managed Identity",
   "managed namespaces only": "managed namespaces only",
-  "ManagedNamespacePreview feature registered successfully!": "ManagedNamespacePreview feature registered successfully!",
-  "_ManagedNamespacePreview feature registered successfully!.comment": "{Locked=\"ManagedNamespacePreview\"}",
   "Manual": "Manual",
   "Manual Deploy": "Manual Deploy",
   "Manually configure settings": "Manually configure settings",
@@ -549,7 +546,6 @@
   "Pipeline": "Pipeline",
   "Pipeline configured": "Pipeline configured",
   "Please complete the authentication in your browser. This window will automatically redirect once login is complete.": "Please complete the authentication in your browser. This window will automatically redirect once login is complete.",
-  "Please register it to continue.": "Please register it to continue.",
   "Please review all the settings before creating your AKS project": "Please review all the settings before creating your AKS project",
   "Please select a deployment to view metrics": "Please select a deployment to view metrics",
   "Please select a subscription first": "Please select a subscription first",
@@ -593,8 +589,6 @@
   "Refreshing": "Refreshing",
   "Register AKS Cluster": "Register AKS Cluster",
   "Register Cluster": "Register Cluster",
-  "Register ManagedNamespacePreview Feature": "Register ManagedNamespacePreview Feature",
-  "_Register ManagedNamespacePreview Feature.comment": "{Locked=\"ManagedNamespacePreview\"}",
   "Registering": "Registering",
   "Registering cluster": "Registering cluster",
   "Registry Name": "Registry Name",
@@ -732,8 +726,6 @@
   "The HTTP path to check for liveness (e.g., /healthz). The probe performs an HTTP GET request to this path.": "The HTTP path to check for liveness (e.g., /healthz). The probe performs an HTTP GET request to this path.",
   "The HTTP path to check for readiness (e.g., /ready). The probe performs an HTTP GET request to this path.": "The HTTP path to check for readiness (e.g., /ready). The probe performs an HTTP GET request to this path.",
   "The HTTP path to check for startup (e.g., /startup). The probe performs an HTTP GET request to this path.": "The HTTP path to check for startup (e.g., /startup). The probe performs an HTTP GET request to this path.",
-  "The ManagedNamespacePreview feature must be registered to create managed namespaces.": "The ManagedNamespacePreview feature must be registered to create managed namespaces.",
-  "_The ManagedNamespacePreview feature must be registered to create managed namespaces..comment": "{Locked=\"ManagedNamespacePreview\"}",
   "The maximum amount of CPU the container can use. If exceeded, the container will be throttled.": "The maximum amount of CPU the container can use. If exceeded, the container will be throttled.",
   "The maximum amount of memory the container can use. If exceeded, the container will be terminated (OOMKilled).": "The maximum amount of memory the container can use. If exceeded, the container will be terminated (OOMKilled).",
   "_The maximum amount of memory the container can use. If exceeded, the container will be terminated (OOMKilled)..comment": "{Locked=\"OOMKilled\"}",

plugins/aks-desktop/locales/en/translation.json

@@ -80,11 +80,6 @@
   "Installing": "Installing",
   "Install Extension": "Install Extension",
   "AKS Preview Extension installed successfully!": "AKS Preview Extension installed successfully!",
-  "The ManagedNamespacePreview feature must be registered to create managed namespaces.": "The ManagedNamespacePreview feature must be registered to create managed namespaces.",
-  "Current state": "Current state",
-  "Please register it to continue.": "Please register it to continue.",
-  "Register ManagedNamespacePreview Feature": "Register ManagedNamespacePreview Feature",
-  "ManagedNamespacePreview feature registered successfully!": "ManagedNamespacePreview feature registered successfully!",
   "Project Name": "Project Name",
   "Checking if another project exists with same name": "Checking if another project exists with same name",
   "Another project already exists with same name. Please choose a different name.": "Another project already exists with same name. Please choose a different name.",

plugins/aks-desktop/src/components/CreateAKSProject/CreateAKSProject.tsx

@@ -45,12 +45,10 @@ function CreateAKSProject() {
             loadingClusters={wizard.azureResources.loadingClusters}
             clusterError={wizard.azureResources.clusterError}
             extensionStatus={wizard.extensionStatus}
-            featureStatus={wizard.featureStatus}
             namespaceStatus={wizard.namespaceCheck}
             clusterCapabilities={wizard.clusterCapabilities.capabilities}
             capabilitiesLoading={wizard.clusterCapabilities.loading}
             onInstallExtension={wizard.extensionStatus.installExtension}
-            onRegisterFeature={wizard.featureStatus.registerFeature}
             onRetrySubscriptions={async () => {
               await wizard.azureResources.fetchSubscriptions();
             }}

plugins/aks-desktop/src/components/CreateAKSProject/components/BasicsStep.stories.tsx

@@ -76,18 +76,10 @@ const BASE_PROPS: BasicsStepProps = {
   clusterError: null,
   totalClusterCount: null,
   extensionStatus: { installed: true, installing: false, error: null, showSuccess: false },
-  featureStatus: {
-    registered: true,
-    state: 'Registered',
-    registering: false,
-    error: null,
-    showSuccess: false,
-  },
   namespaceStatus: { exists: null, checking: false, error: null },
   clusterCapabilities: null,
   capabilitiesLoading: false,
   onInstallExtension: async () => {},
-  onRegisterFeature: async () => {},
   onRetrySubscriptions: async () => {},
   onRetryClusters: async () => {},
   onRefreshCapabilities: () => {},
@@ -203,40 +195,6 @@ ExtensionInstallSuccess.args = {
   extensionStatus: { installed: true, installing: false, error: null, showSuccess: true },
 };
 
-/**
- * The `ManagedNamespacePreview` feature flag is not yet registered.
- * Shows the red error panel with the "Register Feature" button.
- */
-export const FeatureNotRegistered = Template.bind({});
-FeatureNotRegistered.args = {
-  ...BASE_PROPS,
-  formData: { ...BASE_FORM_DATA, subscription: 'sub-123' },
-  featureStatus: {
-    registered: false,
-    state: 'NotRegistered',
-    registering: false,
-    error: null,
-    showSuccess: false,
-  },
-};
-
-/**
- * Feature registration is in progress.
- * The "Register Feature" button shows a spinner and is disabled.
- */
-export const FeatureRegistering = Template.bind({});
-FeatureRegistering.args = {
-  ...BASE_PROPS,
-  formData: { ...BASE_FORM_DATA, subscription: 'sub-123' },
-  featureStatus: {
-    registered: false,
-    state: 'Registering',
-    registering: true,
-    error: null,
-    showSuccess: false,
-  },
-};
-
 /**
  * Project name collides with an existing namespace.
  * The Project Name field shows an error state and a "name taken" message.

plugins/aks-desktop/src/components/CreateAKSProject/components/BasicsStep.tsx

@@ -117,8 +117,7 @@ function RegisterCluster({ cluster, resourceGroup, subscription, tenantId }: Reg
  *
  * Collects the project name, description, Azure subscription, and AKS cluster.
  * Also surfaces pre-flight warnings and errors for the AKS Preview extension,
- * the ManagedNamespacePreview feature flag, cluster readiness, cluster
- * capabilities, and namespace name availability.
+ * cluster readiness, cluster capabilities, and namespace name availability.
  *
  * All stateful logic (focus management, auto-select, option mapping, cluster
  * state derivation) lives in {@link useBasicsStep}. The `RegisterCluster`
@@ -134,12 +133,10 @@ export const BasicsStep: React.FC<BasicsStepProps> = props => {
     loadingClusters,
     clusterError,
     extensionStatus,
-    featureStatus,
     namespaceStatus,
     clusterCapabilities,
     capabilitiesLoading,
     onInstallExtension,
-    onRegisterFeature,
     onRetrySubscriptions,
     onRetryClusters,
     onRefreshCapabilities,
@@ -214,60 +211,6 @@ export const BasicsStep: React.FC<BasicsStepProps> = props => {
         />
       )}
 
-      {/* ManagedNamespacePreview feature flag check */}
-      {featureStatus.registered === false && (
-        <ValidationAlert
-          type="error"
-          message={
-            <Box sx={{ display: 'flex', flexDirection: 'column', gap: 2 }}>
-              <Typography variant="h6" component="div">
-                Feature Flag Required
-              </Typography>
-              <Typography variant="body2">
-                {t(
-                  'The ManagedNamespacePreview feature must be registered to create managed namespaces.'
-                )}
-              </Typography>
-              {featureStatus.state && (
-                <Typography variant="body2">
-                  {t('Current state')}: <strong>{featureStatus.state}</strong>
-                </Typography>
-              )}
-              <Typography variant="body2">{t('Please register it to continue.')}</Typography>
-              {featureStatus.error && (
-                <Typography variant="caption" color="error" sx={{ display: 'block' }}>
-                  {featureStatus.error}
-                </Typography>
-              )}
-              <Button
-                variant="contained"
-                onClick={onRegisterFeature}
-                disabled={featureStatus.registering}
-                sx={{ alignSelf: 'flex-start' }}
-                size="large"
-                aria-busy={featureStatus.registering || undefined}
-              >
-                {featureStatus.registering ? (
-                  <Box display="flex" alignItems="center" gap={1}>
-                    <CircularProgress size={16} color="inherit" aria-hidden="true" />
-                    {t('Registering')}...
-                  </Box>
-                ) : (
-                  t('Register ManagedNamespacePreview Feature')
-                )}
-              </Button>
-            </Box>
-          }
-        />
-      )}
-
-      {featureStatus.showSuccess && (
-        <ValidationAlert
-          type="success"
-          message={'✓ ' + t('ManagedNamespacePreview feature registered successfully!')}
-        />
-      )}
-
       <Box sx={{ display: 'flex', gap: 3, flexDirection: 'column' }}>
         {/* Project Name */}
         <FormControl fullWidth variant="outlined">

plugins/aks-desktop/src/components/CreateAKSProject/hooks/useBasicsStep.test.ts

@@ -86,18 +86,10 @@ function makeProps(overrides: Partial<BasicsStepProps> = {}): BasicsStepProps {
     clusterError: null,
     totalClusterCount: null,
     extensionStatus: { installed: true, installing: false, error: null, showSuccess: false },
-    featureStatus: {
-      registered: true,
-      state: 'Registered',
-      registering: false,
-      error: null,
-      showSuccess: false,
-    },
     namespaceStatus: { exists: null, checking: false, error: null },
     clusterCapabilities: null,
     capabilitiesLoading: false,
     onInstallExtension: vi.fn(),
-    onRegisterFeature: vi.fn(),
     onRetrySubscriptions: vi.fn(),
     onRetryClusters: vi.fn(),
     onRefreshCapabilities: vi.fn(),

plugins/aks-desktop/src/components/CreateAKSProject/hooks/useCreateAKSProjectWizard.test.ts

@@ -89,19 +89,6 @@ vi.mock('./useExtensionCheck', () => ({
   }),
 }));
 
-vi.mock('./useFeatureCheck', () => ({
-  useFeatureCheck: () => ({
-    registered: true,
-    state: null,
-    registering: false,
-    error: null,
-    showSuccess: false,
-    registerFeature: vi.fn(),
-    checkFeature: vi.fn(),
-    clearError: vi.fn(),
-  }),
-}));
-
 vi.mock('./useNamespaceCheck', () => ({
   useNamespaceCheck: () => ({
     exists: false,

plugins/aks-desktop/src/components/CreateAKSProject/hooks/useCreateAKSProjectWizard.ts

@@ -20,7 +20,6 @@ import { STEPS } from '../types';
 import { useAzureResources } from './useAzureResources';
 import { useClusterCapabilities } from './useClusterCapabilities';
 import { useExtensionCheck } from './useExtensionCheck';
-import { useFeatureCheck } from './useFeatureCheck';
 import { useFormData } from './useFormData';
 import { useNamespaceCheck } from './useNamespaceCheck';
 import { useValidation } from './useValidation';
@@ -102,8 +101,6 @@ export interface UseCreateAKSProjectWizardResult {
   azureResources: ReturnType<typeof useAzureResources>;
   /** Extension install status and action for the aks-preview CLI extension. */
   extensionStatus: ReturnType<typeof useExtensionCheck>;
-  /** Feature registration status and action for the required AKS feature flag. */
-  featureStatus: ReturnType<typeof useFeatureCheck>;
   /** Namespace existence check state and action. */
   namespaceCheck: ReturnType<typeof useNamespaceCheck>;
   /** Cluster capability flags (SKU, network policy, add-on status). */
@@ -155,7 +152,6 @@ export function useCreateAKSProjectWizard(): UseCreateAKSProjectWizardResult {
   const azureResources = useAzureResources();
   const clusterCapabilities = useClusterCapabilities();
   const extensionStatus = useExtensionCheck();
-  const featureStatus = useFeatureCheck({ subscription: formData.subscription });
   const namespaceCheck = useNamespaceCheck();
 
   const clustersConf = K8s.useClustersConf();
@@ -169,7 +165,6 @@ export function useCreateAKSProjectWizard(): UseCreateAKSProjectWizardResult {
     activeStep,
     formData,
     extensionStatus,
-    featureStatus,
     namespaceCheck,
     isClusterMissing,
     clusterCapabilities.capabilities
@@ -606,7 +601,6 @@ export function useCreateAKSProjectWizard(): UseCreateAKSProjectWizardResult {
     updateFormData,
     azureResources,
     extensionStatus,
-    featureStatus,
     namespaceCheck,
     clusterCapabilities,
     validation,