RN 0.77 + Old Architecture Crash

[steven-isbell]

We recently adopted this library and it's been a great drop in for the old code push lib. We're seeing the following two crash's on Android and hoping you have some insights

Exception java.lang.RuntimeException:
  at com.facebook.react.bridge.CatalystInstanceImpl.jniLoadScriptFromFile (CatalystInstanceImpl.java)
  at com.facebook.react.bridge.CatalystInstanceImpl.loadScriptFromFile (CatalystInstanceImpl.java:245)
  at com.facebook.react.bridge.JSBundleLoader$2.loadScript (JSBundleLoader.java:46)
  at com.facebook.react.bridge.CatalystInstanceImpl.runJSBundle (CatalystInstanceImpl.java:268)
  at com.facebook.react.ReactInstanceManager.createReactContext (ReactInstanceManager.java:1530)
  at com.facebook.react.ReactInstanceManager.lambda$runCreateReactContextOnNewThread$2 (ReactInstanceManager.java:1226)
  at java.lang.Thread.run (Thread.java:764)

and

Exception com.appzung.codepush.react.CodePushMalformedDataException:
  at com.appzung.codepush.react.CodePushUtils.getJsonObjectFromFile (CodePushUtils.java:202)
  at com.appzung.codepush.react.CodePushUpdateManager.getCurrentPackageInfo (CodePushUpdateManager.java:59)
  at com.appzung.codepush.react.CodePushUpdateManager.getCurrentPackageHash (CodePushUpdateManager.java:109)
  at com.appzung.codepush.react.CodePushNativeModule.isFirstRun (CodePushNativeModule.java:693)
  at java.lang.reflect.Method.invoke
  at com.facebook.react.bridge.JavaMethodWrapper.invoke (JavaMethodWrapper.java:372)
  at com.facebook.react.bridge.JavaModuleWrapper.invoke (JavaModuleWrapper.java:146)
  at com.facebook.jni.NativeRunnable.run (NativeRunnable.java)
  at android.os.Handler.handleCallback (Handler.java:958)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage (MessageQueueThreadHandler.java:27)
  at android.os.Looper.loopOnce (Looper.java:230)
  at android.os.Looper.loop (Looper.java:319)
  at com.facebook.react.bridge.queue.MessageQueueThreadImpl.lambda$startNewBackgroundThread$2 (MessageQueueThreadImpl.java:217)
  at java.lang.Thread.run (Thread.java:1012)
Caused by org.json.JSONException: End of input at character 0 of
  at org.json.JSONTokener.syntaxError (JSONTokener.java:469)
  at org.json.JSONTokener.nextValue (JSONTokener.java:101)
  at org.json.JSONObject.<init> (JSONObject.java:168)
  at org.json.JSONObject.<init> (JSONObject.java:185)
  at com.appzung.codepush.react.CodePushUtils.getJsonObjectFromFile (CodePushUtils.java:199)

Thanks!

[Minishlink]

Hello, could you share more info please?

• @appzung/react-native-code-push version
• @appzung/cli version
• is this a crash that occurs systematically or randomly? Do you reproduce the issue? Is it something that appears in your crash monitoring system? Does it occur for every codepush updates or just some? For every devices?
• do you have hermes enabled?
• could you send a release id where the problem occurs? (eg. https://console.appzung.com/yourorg/releases/RELEASE_ID)

[steven-isbell]

• "@appzung/react-native-code-push": "10.2.4"
• We're not using the AppZung cli, we have a self hosted version
• It appears to be random, I haven't been able to reproduce it, but we've had ~1500 events occur.
• We do have hermes enabled

[Minishlink]

Thanks, can you tell me more about your app's lifecycle? When are codepush updates checked/installed?

[steven-isbell]

When the application first loads we have a top level hook that runs and

1. Checks for an update
2. If the update is available it downloads it
3. It gets applied on the next restart.

Most of the crashes are occurring because the Android device is trying to open the codepush file and getting the first error I listed above from jniLoadScriptFromFile

JSBigFileString::fromPath - Could not open file: /data/user/0/com.project.slug/files/CodePush/8aef36caec188d0f76f36ec243b50545e1caac4bdd6c16f87749e65aef1383e0/CodePush/index.android.bundle

[Minishlink]

Hey, coming back to this. So either the file is not present for some reason, or the filesystem is not available. Do you send push notifications by any chance to your users? Do you see a correlation between when you send push notifications and the number of these crashes?