Skip to content

Commit 111a951

Browse files
committed
Version 3.3.2
~ Fix Server not showing favicon to unsupported clients
1 parent b2c2cc9 commit 111a951

3 files changed

Lines changed: 6 additions & 1 deletion

File tree

bungeecord/src/main/java/com/andre601/oneversionremake/bungeecord/listener/BungeePingListener.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,8 @@ public void onProxyPing(ProxyPingEvent event){
8181
ping.setDescriptionComponent(component);
8282
}
8383

84+
ping.setFavicon(ping.getFaviconObject());
85+
8486
protocol.setProtocol(serverProtocols.get(0));
8587

8688
ping.setVersion(protocol);

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
<properties>
1313
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
14-
<plugin.version>3.3.1</plugin.version>
14+
<plugin.version>3.3.2</plugin.version>
1515
<maven.compiler.target>1.8</maven.compiler.target>
1616
<maven.compiler.source>1.8</maven.compiler.source>
1717
</properties>

velocity/src/main/java/com/andre601/oneversionremake/velocity/listener/VelocityPingListener.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,9 @@ public void onProxyPing(ProxyPingEvent event){
8181
builder.description(ping.getDescriptionComponent());
8282
}
8383

84+
// Prevents breaking favicons
85+
ping.getFavicon().ifPresent(builder::favicon);
86+
8487
event.setPing(builder.build());
8588
}
8689
}

0 commit comments

Comments
 (0)